Added UsageInspectionSuppresions for UnityEditor.Build.*

[JurjenBiewenga]

Fixes #686

All the interfaces in UnityEditor.Build implement the IOrderedCallback interface however I could not figure out how to make the callbackOrder property implicitly used.

[citizenmatt]

Thanks for the contribution, unfortunately, this is not the correct approach. The api.xml file is intended to hold event functions, parsed from the "Messages" section of the Unity documentation. The methods listed in the file are marked as implicitly used by the UsageInspectionsSuppressor, but that is because they are event functions, not because this is how to mark them as in use. It also doesn't work with properties, only methods.

A more appropriate approach would be to add this directly to UsageInspectionsSuppressor, by adding explicit checks for methods and properties, by looking at the short name and verifying that they implement the appropriate interface. E.g.

case IProperty when IsOrderedCallbackMember():
  flags = ImplicitUseKindFlags.Access;
  return true;

and something similar for methods.

The implementation check would probably need to check the method or property's ShortName to see if it's an interesting member, and then call member.GetRootSuperMembers(false) and for each returned member, call rootMember.GetContainingType() and check to see if that type is UnityEditor.Build.IOrderedCallback.

[JurjenBiewenga]

This solution might not work with different Unity versions in this form. I'm not sure how to test that however, any suggestions?

[citizenmatt]

Why do you think it might not work with other Unity versions?

[citizenmatt]

Add another case where the interface is being implicitly implemented via a base class, e.g.

public abstract class Base : IPostprocessBuild
{
  // …
  public abstract void OnPostProcessBuild();
}

and

public class Derived : Base
{
  public override void OnPostProcessBuild(…) { }
}

This should also help check if we can short circuit the type check.

[citizenmatt]

Oh yeah, and can you add an "added" line in the CHANGELOG.md, plugin.xml and resharper-unity.nuspec, too, please?

[JurjenBiewenga]

Where are the plugin.xml and the resharper-unity.nuspec located?

[citizenmatt]

resharper/resharper-unity/src/resharper-unity.resharper.nuspec and rider/src/main/resources/META-INF/plugin.xml

[citizenmatt]

LGTM