Skip to content

Show usage count on properties #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 25, 2019
Merged

Show usage count on properties #1142

merged 10 commits into from
Nov 25, 2019

Conversation

citizenmatt
Copy link
Member

Usage count was missing on properties used in YAML - the usage count was applied to the setter accessor, not the property itself.

Also adds a check to see if the processing should be interrupted.

@citizenmatt citizenmatt added this to the Rider 2019.1 milestone Apr 16, 2019
@citizenmatt citizenmatt self-assigned this Apr 16, 2019
@citizenmatt citizenmatt removed this from the Rider 2019.2.2 milestone Aug 30, 2019
@citizenmatt citizenmatt changed the base branch from 191 to net193 November 18, 2019 22:51
@citizenmatt citizenmatt added this to the Rider 2019.3 milestone Nov 18, 2019
If there are multiple Code Vision highlights on the same range (e.g. property and property setter), the click handler fails to resolve.
Unknown = 0,
None = 1,
UnityType = 2,
EventDefined = 0,
Copy link
Collaborator

@krasnotsvetov krasnotsvetov Nov 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add tests for this case?
See rider\src\test\kotlin\FindUsagesAssetTest.kt

@citizenmatt citizenmatt merged commit 0fd853b into net193 Nov 25, 2019
@citizenmatt citizenmatt deleted the bug/yaml-property-count branch November 25, 2019 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants