Skip to content

Rider 2018.1.3: NUnit.Framework.Ignore attribute causes Unity Edit Mode test to fail #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jorrit-de-vries opened this issue Jul 20, 2018 · 1 comment
Closed

Rider 2018.1.3: NUnit.Framework.Ignore attribute causes Unity Edit Mode test to fail #657

jorrit-de-vries opened this issue Jul 20, 2018 · 1 comment
Assignees
@van800
Milestone
Rider 2018.3

Comments

@jorrit-de-vries
Copy link

jorrit-de-vries commented Jul 20, 2018 •
edited
Loading

When adding an [Ignore("")] attribute to a Unity Edit Mode unit test and this test is run using the Unit Tests window, the unit test fails, while it is correctly ignored in Unity (2018.2 used).

How to produce:

  • Create new Unity Project
  • Create edit mode test assembly
  • Create test script in assembly

`using NUnit.Framework;

[TestFixture]
public class MyScriptTests {

[Test]
//[Ignore("Ignore Test")]
public void MyScriptSomeMethod()
{

}

}`

  • Run tests with this script, tests succeeds
  • Uncomment [Ignore] attribute, run tests, tests fails
  • Run same tests in Unity, tests succeed (or actually it is correctly ignored)
@van800 van800 added this to the Rider 2018.3 milestone Jul 30, 2018
@van800 van800 self-assigned this Jul 30, 2018
van800 added a commit that referenced this issue Aug 17, 2018
@van800
Rider 2018.1.3: NUnit.Framework.Ignore attribute causes Unity Edit Mo…
a218a0f 
…de test to fail #657
van800 added a commit that referenced this issue Aug 20, 2018
@van800
unittesting fixes (#718)
0ef64e6 
* log test result

* fix compile

* Rider 2018.1.3: NUnit.Framework.Ignore attribute causes Unity Edit Mode test to fail #657
@van800
Copy link
Member

van800 commented Aug 20, 2018

Got merged to 2018.3. Builds of 2018.3 are not yet pulic, so please wait till EAP of 2018.3 start later this year. Thanks for submitting this.

@van800 van800 closed this as completed Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@van800 van800

Labels
None yet
Projects
None yet
Milestone
Rider 2018.3
Development

No branches or pull requests
2 participants
@jorrit-de-vries @van800