Specify Types: support named patterns and members #849
Conversation
DedSec256
force-pushed
the
ber.a/annotate
branch
2 times, most recently
from
03963a4 to
8ef21c3
Compare
| let inline (?>) (x: 'a) ([<InlineIfLambda>] f: 'a -> 'b) = | ||
| if isNull x then null else f x |
There was a problem hiding this comment.
Should we maybe do it in a separate PR and use it in more cases right away?
| @@ -208,28 +226,54 @@ module SpecifyTypes = | |||
|
|
|||
| | _ -> () | |||
|
|
|||
| module SpecifyTypesActionHelper = | |||
| open SpecifyTypes | |||
| let executePsiTransaction (node: ITreeNode) (availability: Availability) = | |||
| specifyParameterTypes types (fun x -> x[0].Type) enumerate parameters true | ||
| else | ||
| let types = getFunctionTypeArgs true mfv.FullType | ||
| specifyParameterTypes types id (_.GenericArguments) parameters true |
There was a problem hiding this comment.
Are the parens required here?
There was a problem hiding this comment.
We are currently using .NET 8.0.100 for GitHub Actions, which doesn't support shorthand syntax without parens properly.
We can upgrade it slightly in a separate PR or leave the brackets here.
| inherit FSharpContextActionBase(dataProvider) | ||
|
|
||
| override x.Text = "Add type annotations" | ||
| abstract member IsAvailable: 'a -> bool | ||
| member x.ContextNode = dataProvider.GetSelectedElement<'a>() |
| override x.IsAvailable(_: IUserDataHolder) = | ||
| let node = x.ContextNode | ||
|
|
||
| isNotNull node && isValid (node :> ITreeNode) && |
There was a problem hiding this comment.
Are both isValid and isNotNull checks needed here? Doesn't the first one include the second? Also why is the cast needed?
There was a problem hiding this comment.
Also why is the cast needed?
The type inference has some difficulties, since isValid -- STRP-function
There was a problem hiding this comment.
Oh, wow. That's really unfortunate :(
^ Conflicts: ^ ReSharper.FSharp/src/FSharp/FSharp.Psi.Intentions/src/Intentions/FunctionAnnotationAction.fs
DedSec256
force-pushed
the
ber.a/annotate
branch
from
7d82751 to
fb8fe3d
Compare
Additional entry point for
specify typesvia context actions. Currently supported the same scenarios as for inlay hints materialization.The following PR's will add support for primary constructors / properties with accessors, etc