Fix the illegal lookupClass issue when using MethodHandles.Lookup on JDK 8
#594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhelenskiy
force-pushed
the
custom-lookup
branch
from
b0fdd16 to
c880d09
Compare
zhelenskiy
changed the title
|
@zhelenskiy, please update the PR title and description to indicate what this PR fixes. |
|
@zhelenskiy, please also add an integration test for the issue. |
zhelenskiy
force-pushed
the
custom-lookup
branch
from
c880d09 to
12b598d
Compare
The integration test for this issue is considered too complex, so we decided not to include it, as it would require too much effort. It would be possible to include the whole Kotlin project once it would start working completely fine. |
eupp
changed the title
eupp
changed the title
lookupClass issue when using MethodHandles.Lookup on JDK 8
eupp
requested changes
Apr 7, 2025
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/transformation/LincheckClassVisitor.kt
Outdated
Show resolved
Hide resolved
zhelenskiy
force-pushed
the
custom-lookup
branch
2 times, most recently
from
395ed1c to
ba589f3
Compare
zhelenskiy
force-pushed
the
custom-lookup
branch
from
ba589f3 to
6cb9742
Compare
eupp
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was caused by the fact that
MethodHandles.lookup, needed for custom handling of invoke-dynamic cannot be called from certain locations. In the case of Java > 8, the only limitation isjava.lang.invoke, which is fine. While in Java 8 it also includes all Java stdlib packages. So the workaround was to call a private constructor ofMethodHandlesprivately with reflection.The issue was reproducible on one of the tests from Kotlin compiler repository.