Custom threads: remove run(), remove lambda and remove result

[bbrockbernd]

Cleans up representation of custom (user defined) threads.

• Removes run()
• Removes the two lines related to the lambda
• Removes result
• In collapsed trace shows root elements of the trace in the thread

Note: the root elements in the trace for custom threads still have at .....invoke() this should be fixed in the issue regarding lambdas.

Before:

Detailed trace:
| ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
|                                                                                                Thread 1                                                                                                |                                                                         Thread 2                                                                         |
| ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| SimpleThreadCreationRepresentationTest#1.block(): threw IllegalStateException at BaseRunConcurrentRepresentationTest$testRunWithModelChecker$result$1$1.invoke(RunConcurrentRepresentationTests.kt:40) |                                                                                                                                                          |
|   block(): threw IllegalStateException at SimpleThreadCreationRepresentationTest.block(ThreadCreationRepresentationTest.kt:39)                                                                         |                                                                                                                                                          |
|     thread(block = block$t1$1#1): Thread#2 at SimpleThreadCreationRepresentationTest.block(ThreadCreationRepresentationTest.kt:47)                                                                     |                                                                                                                                                          |
|     switch (reason: waiting for Thread 2 to finish)                                                                                                                                                    |                                                                                                                                                          |
|                                                                                                                                                                                                        | run()                                                                                                                                                    |
|                                                                                                                                                                                                        |   block$t1$1#1.invoke() at ThreadsKt$thread$thread$1.run(Thread.kt:30)                                                                                   |
|                                                                                                                                                                                                        |     invoke() at SimpleThreadCreationRepresentationTest$block$t1$1.invoke(ThreadCreationRepresentationTest.kt:47)                                         |
|                                                                                                                                                                                                        |       SimpleThreadCreationRepresentationTest#1.a ➜ 1 at SimpleThreadCreationRepresentationTest$block$t1$1.invoke(ThreadCreationRepresentationTest.kt:48) |
|                                                                                                                                                                                                        |       SimpleThreadCreationRepresentationTest#1.a = 2 at SimpleThreadCreationRepresentationTest$block$t1$1.invoke(ThreadCreationRepresentationTest.kt:48) |
|                                                                                                                                                                                                        |   result: void                                                                                                                                           |
|     Thread#2.join() at SimpleThreadCreationRepresentationTest.block(ThreadCreationRepresentationTest.kt:50)                                                                                            |                                                                                                                                                          |
|   result: IllegalStateException #1                                                                                                                                                                     |                                                                                                                                                          |
| ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |

After

Detailed trace:
| ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
|                                                                                                Thread 1                                                                                                |                                                                      Thread 2                                                                      |
| ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| SimpleThreadCreationRepresentationTest#1.block(): threw IllegalStateException at BaseRunConcurrentRepresentationTest$testRunWithModelChecker$result$1$1.invoke(RunConcurrentRepresentationTests.kt:40) |                                                                                                                                                    |
|   block(): threw IllegalStateException at SimpleThreadCreationRepresentationTest.block(ThreadCreationRepresentationTest.kt:39)                                                                         |                                                                                                                                                    |
|     thread(block = block$t1$1#1): Thread#2 at SimpleThreadCreationRepresentationTest.block(ThreadCreationRepresentationTest.kt:47)                                                                     |                                                                                                                                                    |
|     switch (reason: waiting for Thread 2 to finish)                                                                                                                                                    |                                                                                                                                                    |
|                                                                                                                                                                                                        | SimpleThreadCreationRepresentationTest#1.a ➜ 1 at SimpleThreadCreationRepresentationTest$block$t1$1.invoke(ThreadCreationRepresentationTest.kt:48) |
|                                                                                                                                                                                                        | SimpleThreadCreationRepresentationTest#1.a = 2 at SimpleThreadCreationRepresentationTest$block$t1$1.invoke(ThreadCreationRepresentationTest.kt:48) |
|     Thread#2.join() at SimpleThreadCreationRepresentationTest.block(ThreadCreationRepresentationTest.kt:50)                                                                                            |                                                                                                                                                    |
|   result: IllegalStateException #1                                                                                                                                                                     |                                                                                                                                                    |
| ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |

[bbrockbernd]

Bring back run() on both detailed and collapsed trace. On collapsed trace do show the direct children of run()

[eupp]

As discussed with @ndkoval, let's do few changes:

1. Leave top-leve run() but always expand it in both short and detailed trace.