Remove access calls from trace

[bbrockbernd]

Closes #537 And was mentioned here: #534 (comment)

Simplifies:

AccessFunctionRepresentationTest.access$inc(AccessFunctionRepresentationTest#1) at AccessFunctionRepresentationTest$block$1.invoke(AccessFunctionRepresentationTest.kt:19)
    AccessFunctionRepresentationTest#1.inc() at AccessFunctionRepresentationTest.access$inc(AccessFunctionRepresentationTest.kt:13)

Example before:

Detailed trace:
| ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
|                                                                                             Thread 1                                                                                             |
| ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
| AccessFunctionRepresentationTest#1.block(): threw IllegalStateException at BaseRunConcurrentRepresentationTest$testRunWithModelChecker$result$1$1.invoke(RunConcurrentRepresentationTests.kt:40) |
|   block(): threw IllegalStateException at AccessFunctionRepresentationTest.block(AccessFunctionRepresentationTest.kt:13)                                                                         |
|     AccessFunctionRepresentationTestKt.runn(block$1) at AccessFunctionRepresentationTest.block(AccessFunctionRepresentationTest.kt:19)                                                           |
|       block$1.invoke() at AccessFunctionRepresentationTestKt.runn(AccessFunctionRepresentationTest.kt:39)                                                                                        |
|         invoke() at AccessFunctionRepresentationTest$block$1.invoke(AccessFunctionRepresentationTest.kt:19)                                                                                      |
|           AccessFunctionRepresentationTest.access$inc(AccessFunctionRepresentationTest#1) at AccessFunctionRepresentationTest$block$1.invoke(AccessFunctionRepresentationTest.kt:19)             |
|             AccessFunctionRepresentationTest#1.inc() at AccessFunctionRepresentationTest.access$inc(AccessFunctionRepresentationTest.kt:13)                                                      |
|               a ➜ 1 at AccessFunctionRepresentationTest.inc(AccessFunctionRepresentationTest.kt:24)                                                                                              |
|               Nested#1.inc2() at AccessFunctionRepresentationTest.inc(AccessFunctionRepresentationTest.kt:24)                                                                                    |
|                 AccessFunctionRepresentationTest.access$inc3(AccessFunctionRepresentationTest#1) at AccessFunctionRepresentationTest$Nested.inc2(AccessFunctionRepresentationTest.kt:32)         |
|                   AccessFunctionRepresentationTest#1.inc3() at AccessFunctionRepresentationTest.access$inc3(AccessFunctionRepresentationTest.kt:13)                                              |
|                     a ➜ 1 at AccessFunctionRepresentationTest.inc3(AccessFunctionRepresentationTest.kt:28)                                                                                       |
|                     a = 2 at AccessFunctionRepresentationTest.inc3(AccessFunctionRepresentationTest.kt:28)                                                                                       |
|   result: IllegalStateException #1                                                                                                                                                               |
| ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |

after:

Detailed trace:
| ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
|                                                                                             Thread 1                                                                                             |
| ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
| AccessFunctionRepresentationTest#1.block(): threw IllegalStateException at BaseRunConcurrentRepresentationTest$testRunWithModelChecker$result$1$1.invoke(RunConcurrentRepresentationTests.kt:40) |
|   block(): threw IllegalStateException at AccessFunctionRepresentationTest.block(AccessFunctionRepresentationTest.kt:13)                                                                         |
|     AccessFunctionRepresentationTestKt.runn(block$1) at AccessFunctionRepresentationTest.block(AccessFunctionRepresentationTest.kt:19)                                                           |
|       block$1.invoke() at AccessFunctionRepresentationTestKt.runn(AccessFunctionRepresentationTest.kt:39)                                                                                        |
|         invoke() at AccessFunctionRepresentationTest$block$1.invoke(AccessFunctionRepresentationTest.kt:19)                                                                                      |
|           AccessFunctionRepresentationTest.inc() at AccessFunctionRepresentationTest$block$1.invoke(AccessFunctionRepresentationTest.kt:19)                                                      |
|             a ➜ 1 at AccessFunctionRepresentationTest.inc(AccessFunctionRepresentationTest.kt:24)                                                                                                |
|             Nested#1.inc2() at AccessFunctionRepresentationTest.inc(AccessFunctionRepresentationTest.kt:24)                                                                                      |
|               AccessFunctionRepresentationTest.inc3() at AccessFunctionRepresentationTest$Nested.inc2(AccessFunctionRepresentationTest.kt:32)                                                    |
|                 a ➜ 1 at AccessFunctionRepresentationTest.inc3(AccessFunctionRepresentationTest.kt:28)                                                                                           |
|                 a = 2 at AccessFunctionRepresentationTest.inc3(AccessFunctionRepresentationTest.kt:28)                                                                                           |
|   result: IllegalStateException #1                                                                                                                                                               |
| ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |

Additionally gets rid of synthetic field accesses:
Before:

|         invoke() at AccessFieldRepresentationTest$block$1.invoke(AccessFunctionRepresentationTest.kt:48)                                                                                      |
|           AccessFieldRepresentationTest.access$getA$p(AccessFieldRepresentationTest#1): 1 at AccessFieldRepresentationTest$block$1.invoke(AccessFunctionRepresentationTest.kt:48)             |
|             AccessFieldRepresentationTest#1.a ➜ 1 at AccessFieldRepresentationTest.access$getA$p(AccessFunctionRepresentationTest.kt:42)                                                      |
|           AccessFieldRepresentationTest.access$setA$p(AccessFieldRepresentationTest#1, 2) at AccessFieldRepresentationTest$block$1.invoke(AccessFunctionRepresentationTest.kt:48)             |
|             AccessFieldRepresentationTest#1.a = 2 at AccessFieldRepresentationTest.access$setA$p(AccessFunctionRepresentationTest.kt:42)                                                      |

After:

|         invoke() at AccessFieldRepresentationTest$block$1.invoke(AccessFunctionRepresentationTest.kt:48)                                                                                      |
|           AccessFieldRepresentationTest#1.a ➜ 1 at AccessFieldRepresentationTest$block$1.invoke(AccessFunctionRepresentationTest.kt:48)                                                       |
|           AccessFieldRepresentationTest#1.a = 2 at AccessFieldRepresentationTest$block$1.invoke(AccessFunctionRepresentationTest.kt:48)                                                       |

[eupp]

While we are here, let's maybe fix .access$ for all cases?

The .access$ methods are generated by the Kotlin compiler to access otherwise inaccessible members (e.g., private) from lambdas, inner classes, etc.:
https://medium.com/@iateyourmic/synthetic-accessors-in-kotlin-a60184afd94e

So it looks like apart from functions, you also need to handle field accesses.

[bbrockbernd]

Good idea, and done!