Fix object creation tracking #426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Before this commit, `ObjectCreationTransformer` tracked only the objects on which `Object::<init>` constructor was called. However, if the instrumented code created a new instance of some `Derived` class, such that its `Base` class is not instrumented, then no `Object::<init>` constructor call would have been tracked. To fix this issue, we now track any `::<init>` constructor call, and keep a counter of uninitialized objects to distringuish between actual constructor calls, and the calls of the base class constructor from the derived class constructor. Signed-off-by: Evgeniy Moiseenko <[email protected]>
eupp
force-pushed
the
obj-creation-tracking-fix
branch
from
719add0 to
3cbce9b
Compare
…y the PR Signed-off-by: Evgeniy Moiseenko <[email protected]>
Signed-off-by: Evgeniy Moiseenko <[email protected]>
ndkoval
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR,
ObjectCreationTransformerinjectedInjections::afterNewObjectCreationonly on the objects on whichObject::<init>constructor was called. However, if the instrumented code created a new instance of someDerivedclass, such that itsBaseclass is not instrumented, then noObject::<init>constructor call would be tracked by the current algorithm (since onlyDerived::<init>will be called from the instrumented code).To fix this issue, we now track any
::<init>constructor call, and keep a counter of uninitialized objects to distinguish between actual constructor calls, and the calls of the base class constructor from the derived class constructor.