Fix local objects detector #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndkoval
approved these changes
Nov 18, 2024
| f.isEnumConstant || | ||
| f.name == "serialVersionUID" | ||
| ) return@traverseObjectGraph null | ||
| if (f.isEnumConstant || f.name == "serialVersionUID") |
There was a problem hiding this comment.
Please always use brackets when the return statement is not on the same line
Signed-off-by: Evgeniy Moiseenko <[email protected]>
Signed-off-by: Evgeniy Moiseenko <[email protected]>
Signed-off-by: Evgeniy Moiseenko <[email protected]>
Signed-off-by: Evgeniy Moiseenko <[email protected]>
Signed-off-by: Evgeniy Moiseenko <[email protected]>
Signed-off-by: Evgeniy Moiseenko <[email protected]>
eupp
force-pushed
the
fix-local-objects-detector
branch
from
77cc10b to
55a6833
Compare
ndkoval
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes our approach to the local objects tracking.
Current approach maintains a map
LocalObject -> List<LocalObject>, which for each local object stores a list of objects immediately reachable from it (via its fields). This map is used to compute a set of local objects reachable from another given local object. Once a local object is assigned to a field of non-local object, all reachable objects are marked as non-local.The problem with this approach is that it is error prone and requires a lot of efforts to maintain the map in the correct state. If the map is not maintained in the correct state, some objects might be incorrectly classified as local (see new test added in this PR).
So instead, in this PR we implement an alternative approach. We still maintain a set of local objects, however when we need to compute a set of objects reachable from given one, we instead traverse the object graph using the utility function.
Thus there is no need to maintain a separate data structure approximating reachable objects.
This PR also should help with #415 , as it would be much more easier to just traverse all objects reachable from the given
Threadobjects once it starts, and mark them as non-local.Note this PR depends on PR #420 , so we first need to merge it, and then rebase.