Skip to content

#200: Fix dev tools window animation flicker #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: staging
Choose a base branch
from

Conversation

AbdullinAM
Copy link
Collaborator

@AbdullinAM AbdullinAM commented Jun 5, 2025

Fix the animation flicker using a workaround suggested by Compose Multiplatform team: controlling window size and position directly, instead of using DialogState.

Using DialogState requires recomposition before the size/position is changed, which causes flicker when the changes are very frequent.

@AbdullinAM AbdullinAM requested a review from sellmair June 5, 2025 13:02
@sellmair
Copy link
Member

sellmair commented Jun 6, 2025

Unfortunately, I saw this when trying to open the dev tools on my machine:

image

@sellmair
Copy link
Member

sellmair commented Jun 6, 2025

image

@sellmair
Copy link
Member

sellmair commented Jun 6, 2025

Screen.Recording.2025-06-06.at.13.59.55.mov

Can you try to reproduce this ?

@AbdullinAM
Copy link
Collaborator Author

@sellmair Yeah, I reproduced them as well. I though I fixed them, but apparently not. I have an idea of whats happening, so it should not be too hard to fix :)

@AbdullinAM AbdullinAM force-pushed the rr/abdullin/devtools-flickering-fix branch from e4cccaa to 9e92d9e Compare June 6, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants