[WIP] update dummy client message format #202
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javizqh
requested changes
Apr 8, 2025
There was a problem hiding this comment.
This file cannot be changed
There was a problem hiding this comment.
The model in this file does not match the expected format by the on_launch_world function in the manager.
Since this file cannot be changed, would you suggest updating the on_launch_world function to match the stated model in this file?
@javizqh
There was a problem hiding this comment.
There is no need to change anything related to this. The only obligatory features are the world and the launch_file_path that must be both strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works, but it can probably be refactored into a cleaner setup.
closes #201