Add ROS 2 support for offline rosbag processing in metrics_carla (issue #708) #709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #708 by adding support for reading and processing rosbag2 files in ROS 2 within metrics_carla.py.
Key changes:
Integrated rosbag2_py, rclpy.serialization, and rosidl_runtime_py to extract messages offline.
Replaced CSV-based processing with direct parsing of ROS 2 bag messages for topics such as /odometry, /clock, /speedometer, and /vehicle_status.
Maintains backward compatibility with previous metrics logic and visualizations.
Validated against recordings from CARLA simulations using ROS 2 Humble.