Skip to content

Increase CI matrix to test against more recent PHPUnit & PHP versions #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 21, 2024

Conversation

Jean85
Copy link
Contributor

@Jean85 Jean85 commented Nov 21, 2024

This is a followup to #348, and tries to add more configuration to test.
Let me know if you want me to follow some specific approach, for now I'm trying a balance between testing all the versions and not having too many jobs to execute.

@Jan0707 WDYT about dropping the custom actions for Composer and migrati to ramsey/composer-install? It has all in one, caching included.

@Jean85
Copy link
Contributor Author

Jean85 commented Nov 21, 2024

SA failure is due to the fact that we're using nikic/php-parser v4, while PHPStan 2 uses v5 internally.

$ composer why-not nikic/php-parser 5
phpunit/php-code-coverage 9.0.0 requires nikic/php-parser (^4.7) 
sebastian/complexity      2.0.0 requires nikic/php-parser (^4.7) 
sebastian/lines-of-code   1.0.0 requires nikic/php-parser (^4.6) 

The same failure does not happen in the CI job with PHPUnit 9.6.0, since it allows v5 since php-code-coverage v9.2.30

I fixed it by running composer update phpunit/php-code-coverage nikic/php-parser -w --minimal-changes, the new --minimal-changes option is great! 😄

@Jean85 Jean85 marked this pull request as ready for review November 21, 2024 11:56
@Jean85 Jean85 requested a review from Jan0707 as a code owner November 21, 2024 11:56
@Jean85
Copy link
Contributor Author

Jean85 commented Nov 21, 2024

@Jan0707 WDYT about dropping the custom actions for Composer and migrati to ramsey/composer-install? It has all in one, caching included.

@Jan0707 I did this in the last commit, let me know if it's ok or if I should drop it.

@Jean85
Copy link
Contributor Author

Jean85 commented Nov 21, 2024

Sorry, I needed to ping you @alexander-schranz 😓

@alexander-schranz
Copy link
Collaborator

Fine with the using ramsey github action.

@alexander-schranz alexander-schranz merged commit 1926a13 into Jan0707:master Nov 21, 2024
13 checks passed
@Jean85 Jean85 deleted the update-gha branch November 21, 2024 12:22
@Jean85 Jean85 mentioned this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants