Skip to content

Fix text color in the event log console when applying dark mode #9739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 5, 2023

Conversation

dlyrsk
Copy link
Contributor

@dlyrsk dlyrsk commented Apr 5, 2023

Fix text color in the event log console when applying dark mode by setting text color to -fx-text-base-color. Also, fix the font size of icons before warning logs.

Fixes #9732

Compulsory checks

Preview Give feedback

Fixed event log console:
Dark mode:
JabRef-9732-t1
Light Mode:
JabRef-9732-t2

…tting text color to `-fx-text-base-color`. Also, fix the font size of icons before warning logs.
koppor
koppor previously approved these changes Apr 5, 2023
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Apr 5, 2023
Co-authored-by: Christoph <[email protected]>
@koppor
Copy link
Member

koppor commented Apr 5, 2023

For a follow-up request, you could even more optimize the appearance:

image

For one-line log messages, they could be centered (!) in the line. currently, they are alinged on top. Especially for the icon, this loocks add.

@calixtus calixtus merged commit f4a542a into JabRef:main Apr 5, 2023
@dlyrsk
Copy link
Contributor Author

dlyrsk commented Apr 6, 2023

For a follow-up request, you could even more optimize the appearance:

image

For one-line log messages, they could be centered (!) in the line. currently, they are alinged on top. Especially for the icon, this loocks add.

Yes, I had a look, and it seems log texts are not centered horizontally. Didn't notice before, though.
Also, the leading icons of log texts need to be centered(not so apparent in the image).
I'll have a look at this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark theme: Event log. Output not readable
5 participants