Skip to content

Fix doab fetcher #9572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 19, 2023
Merged

Fix doab fetcher #9572

merged 2 commits into from
Jan 19, 2023

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Jan 18, 2023 •
edited
Loading

Fixes #9571
Fixes https://github.com/JabRef/jabref-issue-melting-pot/issues/75

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr
Fix date parsing for Doab fetcher
e1a9b5e 
Fixes #9571
Fixes JabRef/jabref-issue-melting-pot#75
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fixDoabFetcher
1dd92ca 
* upstream/main: (23 commits)
  Sort unique library suffix by length (#9568)
  Avoid using Globals.entryTypeManager
  try with liberica jdk
  test with unsigned image
  adjust dmg scpt and add mac sign id
  don't use keychain profile
  use older one
  return true in case security keychain not existing
  readd old codesiginng steps
  codesign image with timestamp
  read app image
  fuu yaml
  again
  try contains
  try to add braces
  fix error in yaml
  test new codesigning
  Test entries equality based on their citation key
  Fix failing tests
  Detect more cases when an entry is modified
  ...

# Conflicts:
#	CHANGELOG.md
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 18, 2023
@ThiloteE
Copy link
Member

Tested. Fixed my issue 👍 :-)

@Siedlerchr
Copy link
Member Author

MathScinet fails, but not relevant to this pr

@Siedlerchr Siedlerchr merged commit b0fc66b into main Jan 19, 2023
@Siedlerchr Siedlerchr deleted the fixDoabFetcher branch January 19, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DOAB fetcher throws exception when searching for "politik"
2 participants
@Siedlerchr @ThiloteE