Fixed the issue where import hangs for ris files with "ER - " failed #7737 #7755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add/extend the unit tests for that case? |
Siedlerchr
requested changes
May 20, 2021
| @Override | ||
| public ParserResult importDatabase(BufferedReader reader) throws IOException { | ||
| List<BibEntry> bibitems = new ArrayList<>(); | ||
|
|
||
| // use optional here, so that no exception will be thrown if the file is empty | ||
| String linesAsString = reader.lines().reduce((line, nextline) -> line + "\n" + nextline).orElse(""); | ||
|
|
||
| String[] entries = linesAsString.replace("\u2013", "-").replace("\u2014", "--").replace("\u2015", "--") | ||
| .split("ER -.*\\n"); | ||
| entries = linesAsString.replace("\u2013", "-").replace("\u2014", "--").replace("\u2015", "--") |
There was a problem hiding this comment.
This is not what I meant with tests. Have a look at the RISImporterTestFiles class.
It searches for test files in /src/test/resources/org/jabref/logic/importer/fileformat that ar named with RISImporterTest....ris
and have a corresponding .bib file with the same name
So you create a minimal RIS file with the ER at the end and a corresponding bib files
This way you can test that the import succeeds without errors
Siedlerchr
added
the
status: changes required
|
I did a follow up PR with the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed the issue where import hangs for ris files with "ER - " failed #7737
fixes #7737
The test file in issue#7737 like error1.ris and error2.ris have a same problem that the last line "ER - " with no line break(/n) , so it isn't eliminate by split("ER -.\n") , use split("ER -.*(\n)*") can solve this problem
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)