Skip to content

Fix#7195 partly Opacity of disabled icon-buttons #7655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2021
Merged

Fix#7195 partly Opacity of disabled icon-buttons #7655

merged 2 commits into from
Apr 23, 2021

Conversation

JavuesZhang
Copy link
Contributor

@JavuesZhang JavuesZhang commented Apr 20, 2021 •
edited
Loading

Fixes #7195
Opacity of disabled icon-buttons

Add the disabled icon style in Base.css

  • No tabs opened:
    i1

  • Open a tab and do not select any entry:
    i2

  • Select an entry in the opened tab:
    i3

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@JavuesZhang
Fix#7195 partly
d2ff9e1 
Opacity of disabled icon-buttons
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Apr 20, 2021
calixtus
calixtus approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@calixtus calixtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Thanks.

@Siedlerchr Siedlerchr merged commit 429b3d0 into JabRef:main Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@calixtus calixtus calixtus approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unselect entries in the main table and opacity of disabled icon-buttons
3 participants
@JavuesZhang @Siedlerchr @calixtus