Fix version check for alpha3 #13242
Closed
Fix version check for alpha3 #13242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trag-bot[bot]](https://avatars.githubusercontent.com/in/856808?s=60&v=4){kind=small}
Siedlerchr
added
the
status: ready-for-review
subhramit
reviewed
Jun 3, 2025
Co-authored-by: Subhramit Basu <[email protected]>
|
@trag-bot didn't find any issues in the code! ✅✨ |
koppor
reviewed
Jun 3, 2025
| @@ -306,6 +306,13 @@ void stableShouldNotBeUpdatedToBeta() { | |||
| assertFalse(stable.shouldBeUpdatedTo(beta)); | |||
| } | |||
|
|
|||
| @Test | |||
| void alpha3IsNewerThanAlpha2WithoutDot() { | |||
| Version alphaNewer = Version.parse("6.0-alpha.3-2025-04-27--c52dc44"); | |||
There was a problem hiding this comment.
Mabye the issue is obsolete because you fixed gitversion?
There was a problem hiding this comment.
But then, this PR is not needed, because there is no dot. See #13093 (comment)
|
Test:
Then it should not report that a newer version exists. |
|
when running jabgui from gradle you get version 100 |
koppor
added
the
dev: binaries
Ah, damn it. Then, we tell the CI to generate a binary.
|
|
The build of this PR is available at https://builds.jabref.org/pull/13242/merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/JabRef/jabref-issue-melting-pot/issues/877
We have dot and a version without a dot between the version number.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)