Skip to content

Add -ea workflow (both JDK-ea and JavaFX-ea) #13056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
May 5, 2025
Merged

Add -ea workflow (both JDK-ea and JavaFX-ea) #13056

merged 19 commits into from
May 5, 2025

Conversation

koppor
Copy link
Member

@koppor koppor commented May 4, 2025

Ports https://github.com/JabRef/jabref/blob/v6.0-alpha2/.github/workflows/deployment-jdk-ea.yml to here


Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [.] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [.] Tests created for changes (if applicable)
  • [.] Manually tested changed features in running JabRef (always required)
  • [.] Screenshots added in PR description (if change is visible to the user)
  • [.] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [.] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor changed the title Add -ea worklfow (both JDK-ea and JavaFX-ea) Add -ea workflow (both JDK-ea and JavaFX-ea) May 4, 2025
Copy link
Contributor

github-actions bot commented May 4, 2025

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor
Copy link
Member Author

koppor commented May 5, 2025

Works

image

@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label May 5, 2025
@koppor koppor marked this pull request as ready for review May 5, 2025 07:11
calixtus
calixtus previously approved these changes May 5, 2025
Copy link

trag-bot bot commented May 5, 2025

@trag-bot didn't find any issues in the code! ✅✨

@koppor koppor merged commit e984f71 into main May 5, 2025
2 checks passed
@koppor koppor deleted the enable-jdk25-build branch May 5, 2025 07:40
@koppor koppor mentioned this pull request May 5, 2025
6 tasks
@Siedlerchr
Copy link
Member

Mac workflow needs to be updated to reflect the latest changes! from #13032

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev: ci-cd status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants