Skip to content

Add Crowdin action #13007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 27, 2025
Merged

Add Crowdin action #13007

merged 6 commits into from
Apr 27, 2025

Conversation

koppor
Copy link
Member

@koppor koppor commented Apr 27, 2025

Follow-up to #12990.

  • Fixes paths in /crowdin.yml
  • Swtiches from crowdin-config to crowdin action

Refs crowdin/github-action#274

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [.] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [.] Tests created for changes (if applicable)
  • [.] Manually tested changed features in running JabRef (always required)
  • [.] Screenshots added in PR description (if change is visible to the user)
  • [.] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [.] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor mentioned this pull request Apr 27, 2025
23 tasks
Comment on lines 14 to 41
if: github.repository == 'JabRef/jabref'
runs-on: ubuntu-latest

steps:
- name: Checkout
uses: actions/checkout@v4

- name: crowdin action
uses: crowdin/github-action@v2
with:
upload_sources: false
upload_translations: true
upload_language: de
download_translations: true
localization_branch_name: l10n_crowdin_translations
create_pull_request: true
pull_request_title: 'New Crowdin Translations'
pull_request_body: 'New Crowdin translations by [Crowdin GH Action](https://github.com/crowdin/github-action)'
pull_request_base_branch_name: 'main'
dryrun_action: true
env:
GITHUB_TOKEN: ${{ secrets.GH_TOKEN_JABREF_MACHINE_PR_APPROVE }}

# A numeric ID, found at https://crowdin.com/project/<projectName>/tools/api
CROWDIN_PROJECT_ID: ja294858bref

# Visit https://crowdin.com/settings#api-key to create this token
CROWDIN_PERSONAL_TOKEN: ${{ secrets.CROWDIN_PERSONAL_TOKEN }}

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
Copy link

trag-bot bot commented Apr 27, 2025

@trag-bot didn't find any issues in the code! ✅✨

@koppor
Copy link
Member Author

koppor commented Apr 27, 2025

Reads good:

image

PR: #13008 --> 33fc783 (#13008)

I close the PR 13008 since it contains this PR, too.

@koppor koppor marked this pull request as ready for review April 27, 2025 14:21
@koppor koppor merged commit ef3d440 into main Apr 27, 2025
2 checks passed
@koppor koppor deleted the use-crowdin-action branch April 27, 2025 14:21
Copy link
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

Copy link

trag-bot bot commented Apr 27, 2025

@trag-bot didn't find any issues in the code! ✅✨

Siedlerchr added a commit that referenced this pull request Apr 27, 2025
…multimodule-followup

* 'multimodule-followup' of github.com:JabRef/jabref:
  Fix import order & OpenRewrite
  Add PR link to changelog
  Add Crowdin action (#13007)
  Bump tech.units:indriya from 2.2.2 to 2.2.3 (#13006)
  Bump org.openrewrite.recipe:rewrite-recipe-bom from 3.5.0 to 3.7.0 (#13005)
  Bump com.konghq:unirest-java-core from 4.4.5 to 4.4.6 (#13004)
@koppor
Copy link
Member Author

koppor commented Apr 29, 2025

Drawback: JabRef Machine cannot approve its own PRs:

image

image

@koppor koppor mentioned this pull request Apr 29, 2025
koppor added a commit that referenced this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant