Fix issue 12889 #12892
Fix issue 12889 #12892
Conversation
![trag-bot[bot]](https://avatars.githubusercontent.com/in/856808?s=60&v=4){kind=small}
| return downloadAutomatically.get(); | ||
| } | ||
|
|
||
| public void setDownloadAutomatically(boolean shouldDownload) { |
There was a problem hiding this comment.
Boolean method parameters should be avoided in public methods. It's better to create distinct methods for different actions to improve code readability and maintainability.
CHANGELOG.md
Outdated
| ### Added | ||
|
|
||
| - We added automatic PDF downloads for arXiv entries when the "Download referenced files" option is enabled in Web Search preferences [#12889](https://github.com/JabRef/jabref/issues/12889) |
There was a problem hiding this comment.
Why did you add your own "Added" section when it already exists? Please see the structure and adjust.
CHANGELOG.md
Outdated
| @@ -64,6 +68,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv | |||
|
|
|||
| ### Fixed | |||
|
|
|||
| - We fixed an issue where warning signs were improperly positioned next to text fields containing capital letters. [#12884](https://github.com/JabRef/jabref/issues/12884) | |||
There was a problem hiding this comment.
Artifact from another PR (probably upstream/main is not synced with your local branch. Please take the latest pull).
| /** | ||
| * Creates a new IconValidationDecorator with default position CENTER_LEFT. | ||
| * This position is chosen to better align with text content regardless of case. | ||
| */ | ||
| public IconValidationDecorator() { | ||
| this(Pos.BOTTOM_LEFT); | ||
| this(Pos.CENTER_LEFT); |
There was a problem hiding this comment.
Why?
Changes from another PR. Please sync.
| } catch (NoSuchFileException e) { | ||
| LOGGER.error("Could not find file: {}", styleFile, e); |
There was a problem hiding this comment.
What if both internal and external files cannot be loaded? Why was this removed?
madanhk18
force-pushed
the
fix-issue-12889
branch
from
0f05cda to
17f3d9d
Compare
|
Your code currently does not meet JabRef's code guidelines. We use Checkstyle to identify issues. You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. To see the test output, locate "Tests / Checkstyle (pull_request)" and click on it. In case of issues with the import order, double check that you activated Auto Import. You can trigger fixing imports by pressing Ctrl+Alt+O to trigger Optimize Imports. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues, commit, and push. |
| @@ -150,6 +149,18 @@ public static Optional<CitationStyle> createCitationStyleFromFile(final String s | |||
| return Optional.empty(); | |||
| } | |||
|
|
|||
| // First try to load as external file | |||
| Path externalPath = Path.of(styleFile); | |||
There was a problem hiding this comment.
wtf this has nothing do with files
Closes #12889
changes :
I made enhancements to the Entry Editor, specifically in the General section. Now, when a field (such as a URL) contains an HTTP/HTTPS link and the user double-clicks on it, the link is automatically takes it to dowload PDF through browser. This improves the workflow for users who often deal with direct document links by making it easier and faster to download referenced PDFs.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)