Added example questions to AI chat #12747
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -10,7 +10,9 @@ | |||||||
| import javafx.collections.ObservableList; | ||||||||
| import javafx.fxml.FXML; | ||||||||
| import javafx.scene.control.Button; | ||||||||
| import javafx.scene.control.Hyperlink; | ||||||||
| import javafx.scene.control.Label; | ||||||||
|
There was a problem hiding this comment.
Suggested change
this is needed for my code suggestion to work properly. |
||||||||
| import javafx.scene.layout.HBox; | ||||||||
| import javafx.scene.layout.VBox; | ||||||||
| import javafx.scene.paint.Color; | ||||||||
|
|
||||||||
|
|
@@ -46,6 +48,11 @@ | |||||||
| public class AiChatComponent extends VBox { | ||||||||
| private static final Logger LOGGER = LoggerFactory.getLogger(AiChatComponent.class); | ||||||||
|
|
||||||||
| // Example Questions | ||||||||
| private static final String EXAMPLE_QUESTION_1 = Localization.lang("What is the goal of the paper?"); | ||||||||
| private static final String EXAMPLE_QUESTION_2 = Localization.lang("Which methods were used in the research?"); | ||||||||
| private static final String EXAMPLE_QUESTION_3 = Localization.lang("What are the key findings?"); | ||||||||
|
|
||||||||
| private final AiService aiService; | ||||||||
| private final ObservableList<BibEntry> entries; | ||||||||
| private final BibDatabaseContext bibDatabaseContext; | ||||||||
|
|
@@ -57,11 +64,17 @@ public class AiChatComponent extends VBox { | |||||||
|
|
||||||||
| private final ObservableList<Notification> notifications = FXCollections.observableArrayList(); | ||||||||
|
|
||||||||
|
|
||||||||
|
|
||||||||
|
|
||||||||
| @FXML private Loadable uiLoadableChatHistory; | ||||||||
| @FXML private ChatHistoryComponent uiChatHistory; | ||||||||
| @FXML private Button notificationsButton; | ||||||||
| @FXML private ChatPromptComponent chatPrompt; | ||||||||
| @FXML private Label noticeText; | ||||||||
| @FXML private Hyperlink exQuestion1; | ||||||||
|
There was a problem hiding this comment. @palukku added inline FXML annotations There was a problem hiding this comment.
Suggested change
|
||||||||
| @FXML private Hyperlink exQuestion2; | ||||||||
| @FXML private Hyperlink exQuestion3; | ||||||||
| @FXML private HBox exQuestionBox; | ||||||||
|
|
||||||||
| public AiChatComponent(AiService aiService, | ||||||||
| StringProperty name, | ||||||||
|
|
@@ -94,6 +107,8 @@ public void initialize() { | |||||||
| initializeChatPrompt(); | ||||||||
| initializeNotice(); | ||||||||
| initializeNotifications(); | ||||||||
| sendExampleQuestions(); | ||||||||
| initializeExampleQuestions(); | ||||||||
| } | ||||||||
|
|
||||||||
| private void initializeNotifications() { | ||||||||
|
|
@@ -111,6 +126,35 @@ private void initializeNotice() { | |||||||
| noticeText.setText(newNotice); | ||||||||
| } | ||||||||
|
|
||||||||
| private void initializeExampleQuestions() { | ||||||||
kaushikaW marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
| exQuestion1.setText(EXAMPLE_QUESTION_1); | ||||||||
| exQuestion2.setText(EXAMPLE_QUESTION_2); | ||||||||
| exQuestion3.setText(EXAMPLE_QUESTION_3); | ||||||||
| } | ||||||||
|
|
||||||||
| private void sendExampleQuestions() { | ||||||||
kaushikaW marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
| addExampleQuestionAction(exQuestion1); | ||||||||
| addExampleQuestionAction(exQuestion2); | ||||||||
| addExampleQuestionAction(exQuestion3); | ||||||||
| } | ||||||||
|
|
||||||||
| private void addExampleQuestionAction(Hyperlink hyperlink) { | ||||||||
|
There was a problem hiding this comment. The method addExampleQuestionAction contains nested logic that could be simplified by returning early when the hyperlink text is already in the chat history, following the fail-fast principle. |
||||||||
| if (chatPrompt.getHistory().contains(hyperlink.getText())) { | ||||||||
InAnYan marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
| exQuestionBox.getChildren().remove(hyperlink); | ||||||||
| if (exQuestionBox.getChildren().size() == 1) { | ||||||||
| this.getChildren().remove(exQuestionBox); | ||||||||
| } | ||||||||
InAnYan marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
| return; | ||||||||
| } | ||||||||
| hyperlink.setOnAction(event -> { | ||||||||
| onSendMessage(hyperlink.getText()); | ||||||||
| exQuestionBox.getChildren().remove(hyperlink); | ||||||||
| if (exQuestionBox.getChildren().size() == 1) { | ||||||||
| this.getChildren().remove(exQuestionBox); | ||||||||
| } | ||||||||
| }); | ||||||||
| } | ||||||||
|
|
||||||||
| private void initializeChatPrompt() { | ||||||||
| notificationsButton.setOnAction(event -> | ||||||||
| new PopOver(new NotificationsComponent(notifications)) | ||||||||
|
|
||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Emtpy line missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed these in #12966