Skip to content

Simplify hide tabbar #12496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Simplify hide tabbar #12496

merged 2 commits into from
Feb 14, 2025

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented Feb 13, 2025

Follow up to #12395
Simplified and some quick code cleanups
@priyanshu16095 please check

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@calixtus calixtus added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers dev: code-quality Issues related to code or architecture decisions labels Feb 13, 2025
Copy link
Contributor

github-actions bot commented Feb 13, 2025

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@priyanshu16095
Copy link
Contributor

priyanshu16095 commented Feb 13, 2025

@calixtus I've checked it locally on my machine, and it works fine.
I’ve also learned from the improvements. Thanks for your guidance!

@subhramit subhramit added this pull request to the merge queue Feb 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 14, 2025
@subhramit subhramit added this pull request to the merge queue Feb 14, 2025
Merged via the queue into main with commit 0a25666 Feb 14, 2025
1 check passed
@subhramit subhramit deleted the simplify-hide-tabbar branch February 14, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev: code-quality Issues related to code or architecture decisions status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants