Skip to content

GVKParser handle publication year correctly #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

GVKParser handle publication year correctly #1069

wants to merge 1 commit into from

Conversation

teertinker
Copy link
Contributor

exchanged the field "date" with "year" to import GVK entries correctly.

Publication year was previously put to date when fetching entry-> now to year

  • Sorry if I broke any conventions of changing code/testing...

Publication year was previously put to date when fetching entry-> now to year
@koppor
Copy link
Member

koppor commented Mar 31, 2016

GVK's date is always 4 digits?

@teertinker
Copy link
Contributor Author

I use it a lot, and never got other "dates" than 4-digits.

@matthiasgeiger
Copy link
Member

@koppor You changed this in b2c8db5 from year to date.

The reason seems to be related to #1018: GVK returns Biblatex entries (regardless of the chosen mode)...

@koppor
Copy link
Member

koppor commented Apr 1, 2016

OK for revert. Current JabRef displays "year" in the "Required fields", which it IMHO did not back in 2015.

@simonharrer
Copy link
Contributor

Reverted in 93fdb02

Thanks for the help, especially @teertinker 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants