Skip to content

Fix group scrolling #10523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 21, 2023
Merged

Fix group scrolling #10523

merged 5 commits into from
Oct 21, 2023

Conversation

koppor
Copy link
Member

@koppor koppor commented Oct 18, 2023

Fixes #9754

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

koppor and others added 2 commits October 18, 2023 23:33
Co-authored-by: Christoph <[email protected]>
Co-authored-by: Carl Christian Snethlage <[email protected]>
Co-authored-by: Christoph <[email protected]>
Co-authored-by: Carl Christian Snethlage <[email protected]>
calixtus
calixtus previously approved these changes Oct 18, 2023
@calixtus calixtus enabled auto-merge October 18, 2023 21:46
@koppor koppor disabled auto-merge October 18, 2023 21:50
@Siedlerchr
Copy link
Member

Siedlerchr commented Oct 18, 2023

test with multiple libraries and different sized group trees and collapsed/expanded

@koppor
Copy link
Member Author

koppor commented Oct 18, 2023

We don't get the right number of tree nodes:

groupTree.getChildrenUnmodifiable() 5
nodesSize 3

@koppor
Copy link
Member Author

koppor commented Oct 21, 2023

We don't get the right number of tree nodes:

The number can be retrieved by groupTree.getExpandedItemCount()

It is difficult to get the height of a concrete group. Only the text height is known, but not with borders. With the heuristics * 2.0, on can get from the text height to the total height.

Tested with 50 groups. Worked fine.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2023

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@calixtus calixtus added this pull request to the merge queue Oct 21, 2023
Merged via the queue into main with commit 0768e1b Oct 21, 2023
@calixtus calixtus deleted the fix-scroll-speed branch October 21, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quirks with groups panel scrolling when adding groups as subgroups or adding items to groups
3 participants