Skip to content

Fixed groups scrolling #10488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 16, 2023
Merged

Fixed groups scrolling #10488

merged 6 commits into from
Oct 16, 2023

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented Oct 12, 2023

Fixed #9754

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@tobiasdiez
Copy link
Member

tobiasdiez commented Oct 13, 2023

Thanks! The "always scroll to bottom" bug seems to be fixed, nice. For my taste, the scroll speed however is too slow now. Could it be that the speed is proportional to the number of groups? (Looking at the code it seems to always scroll a certain percentage of the whole view). I think it would be easier to make it an absolute value (i.e. 4 rows every second or so).

@Siedlerchr Siedlerchr added this to the 5.11 milestone Oct 16, 2023
@Siedlerchr Siedlerchr enabled auto-merge October 16, 2023 10:43
@Siedlerchr Siedlerchr added this pull request to the merge queue Oct 16, 2023
Merged via the queue into main with commit 87c3676 Oct 16, 2023
@Siedlerchr Siedlerchr deleted the fix-group-scrolling branch October 16, 2023 11:01
@tobiasdiez
Copy link
Member

@Siedlerchr did you saw my comment? For me it now takes 2 seconds to move down by one group...

@Siedlerchr
Copy link
Member

Follow up

@koppor
Copy link
Member

koppor commented Oct 16, 2023

Merged, because JabRef was unusable before. Follow-up takes more time than 10 minutes.

@tobiasdiez
Copy link
Member

Sure, no problem. But next time please add a short comment, and reopen the issue.

@AEgit
Copy link

AEgit commented Oct 17, 2023

I think it would be easier to make it an absolute value (i.e. 4 rows every second or so).

Making it an absolute value in general, would probably make it too slow for large databases (?). Instead I would suggest a lower limit on the scrolling speed, but otherwise keep the current implementation (see also my comments here: #9754 (comment)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quirks with groups panel scrolling when adding groups as subgroups or adding items to groups
6 participants