Skip to content

Fix triggers for deployment #10319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Fix triggers for deployment #10319

merged 1 commit into from
Sep 4, 2023

Conversation

koppor
Copy link
Member

@koppor koppor commented Sep 4, 2023

We had the issue that the deployment workflow as not triggered for some PRs. See #9769 (comment).

The reason was a wrong trigger. We had the idea that binaries should only be created if there actually was changed something leading to changes in the binaries. Only changing tests does not lead to a change in the binary. For instance, test-only PRs do not change the binary. -- GitHub's branch protection rules demand that the workflows run. Regardless if the trigger ignores the changes. Thus, either make the workflows success optional - or trigger the workflow always.

Since test-only PRs are very seldom and we do want to have the deplyoment required, I remove the "filter" at the trigger.

Kind of hotfix.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor enabled auto-merge September 4, 2023 17:27
@koppor
Copy link
Member Author

koppor commented Sep 4, 2023

Needs to be tested. Test PR is #10309.

Therefore, I merge and then test at the PR (with re-activated branching rules)

@koppor koppor disabled auto-merge September 4, 2023 17:28
@koppor koppor merged commit 9d3ea50 into main Sep 4, 2023
@koppor koppor deleted the fix-triggers branch September 4, 2023 17:28
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant