Preventing library disappearing when closing tab #12909
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have two databases and the welcome tab open, then close the tab directly to the right of the welcome tab. The top bar will be hidden resulting in you "losing" the other database.
Now if a user closes a tab beside the Home Page tab and there are other libraries active it will go to the other library instead of the Home page
This reverts commit 144b782.
![trag-bot[bot]](https://avatars.githubusercontent.com/in/856808?s=60&v=4){kind=small}
| @@ -344,6 +344,21 @@ private void initBindings() { | |||
| stateManager.setActiveDatabase(libraryTab.getBibDatabaseContext()); | |||
| stateManager.activeTabProperty().set(Optional.of(libraryTab)); | |||
| } else if (selectedTab == null || selectedTab instanceof WelcomeTab) { | |||
| if (stateManager.getActiveDatabase().isPresent()) { | |||
There was a problem hiding this comment.
The code should follow the fail fast principle by immediately handling invalid states and returning early instead of nesting logic inside else branches. The current implementation nests logic inside an if statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12894
Fixes a bug that caused a library to be hidden if you have two libraries and the Welcome tab open, then close the tab directly to the right of the Welcome tab.
Added a check to see if the Welcome tab was selected automatically after a library is closed, and if so, the next tab is selected instead.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)