Library disappeared and Welcome tab is shown instead

[InAnYan]

JabRef version

Latest development branch build (please note build date below)

Operating system

GNU / Linux

Details on version and operating system

Arch Linux (MATE DE)

Checked with the latest development build (copy version output from About dialog)

• I made a backup of my libraries before testing the latest development version.
• I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

1. Open JabRef.

"Welcome tab" appears.

2. Create a new library (button in the upper-left corner).
3. Create another library.

Three tabs are listed in the upper bar: "Welcome", "untitled", "untitled".

4. Click on the 2nd library (first "untitled", the first after "Welcome").
5. Close the 2nd library (via cross near the name).

"Welcome" tab appears, instead of other "untitled" library.

If you instead delete the second "untitled" library (which is the 3rd in step 3), this issue won't appear.

Appendix

No response

[InAnYan]

This PR introduced "Welcome tab": #12461. Maybe you can spot a bug there 😋

[Zurtar]

/assign-me

[github-actions]

👋 Hey @Zurtar, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

[Zurtar]

I've started working on the issue but I need a bit of clarification. What is the preferred behaviour supposed to be? The reason the second library is "lost" is due to how the tab bar is hidden (#12395), the check to hide the tab bar only considers open libraries and doesn't include the welcome tab. The process looks like this:

1. Initially the Welcome tab and two library tabs are open
2. The user closes the tab directly to the right of the welcome tab, causing the new selected tab to "shift left" focusing the welcome tab
3. A change in selection is fired, causing a check to hide the top app bar, which counts the number of open databases, and then if there is only a single one (and the user doesn't have the setting to hide disabled) it hides the tab bar. However because the Welcome tab is selected you "lose" the second library

The two options to fix this seem to be:

• Keep the tab bar visible when there's one library and the Welcome tab open
• Swap focus to the remaining library and hide the tab bar

I'd appreciate some direction on which solution to go with.

[InAnYan]

Hi, Zurtar! Thanks for thorough examination!

I think a typical user expects the 2nd variant: hide the tab bar (which "contains" "Welcome" tab and a library), and show the library