Skip to content

fix(deps): bump bip32 python module to v3.4 #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

epiccurious
Copy link
Contributor

@epiccurious epiccurious commented Jun 26, 2024

Closes #178.

The version Yeti's currently installing is 3.1, but that version doesn't exist in the pip repository.

if not subprocess.run("python3 -c 'import bip32' 2> /dev/null", shell=True, check=False).returncode == 0:
    subprocess.run('pip3 install bip32==3.1', shell=True, check=False)

Running pip install bip32 on my local machine installs version 3.4.

To fix, bump the version in initialize to pip install bip32=3.4.

@epiccurious
Copy link
Contributor Author

Setting as a draft to test the initialization process on Ubuntu 24, 22, and 20.

@epiccurious epiccurious marked this pull request as draft June 26, 2024 11:29
@epiccurious epiccurious changed the title fix(deps): bump BIP32 module to v3.4 fix(deps): bump bip32 python module to v3.4 Jun 26, 2024
@epiccurious epiccurious marked this pull request as ready for review June 26, 2024 13:51
@epiccurious
Copy link
Contributor Author

Tested on Proxmox VMs running Ubuntu 24, 22, and 20. MR is ready for review.

@epiccurious epiccurious marked this pull request as draft June 26, 2024 13:52
@epiccurious epiccurious marked this pull request as ready for review June 26, 2024 13:57
@epiccurious epiccurious marked this pull request as draft June 28, 2024 11:47
@epiccurious
Copy link
Contributor Author

The issue is with coincurve, which is a dependency for bip32.

Tried all three of these on a fresh install of Ubuntu 24, but they fail for 'NoneType' object is not callable:

pip3 install bip32==3.1
pip3 install bip32==3.4
pip3 install bip32

@epiccurious
Copy link
Contributor Author

When you run pip3 install bip32, it pulls in a coincurve version < 19 and >= 15.0, so it grabs version 18, which fails.

Also, pip3 install coincurve==18 fails.

The next step might be to open an issue upstream on the coincurvew repo. This issue doesn't seem to have been opened yet - see link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python bip32 dependency is failing to install
1 participant