[BE-221] feat: 이메일 수동으로 보내는 api 에서 응답 값 설정 #464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
프론트로 응답값을 반환하기 위해 SendEmailManuallyResponse를 작성했습니다.
이메일 전송 성공과 실패일 경우 둘 다 추가해 놓았습니다.
Response 값을 반환할 수 있게 API를 수정하였습니다.
xxbeann
requested review from
Profile-exe,
Woojae-Jeong,
aiaiaiai1 and
LJH098
📝 테스트 커버리지 리포트입니다
|
Profile-exe
reviewed
Feb 19, 2025
...pi/src/main/java/com/jnu/ticketapi/api/council/model/response/SendEmailManuallyResponse.java
Show resolved
Hide resolved
📝 테스트 커버리지 리포트입니다
|
|
Profile-exe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
주요 변경사항
{ "message": "메일 전송에 성공하셨습니다." }위와 같은 방식으로 응답 값을 반환하는 기능을 구현했습니다.
리뷰어에게...
현재 ResponseMessage에서 이메일 전송 성공과 실패 메시지를 모두 관리하고 있는데,
따로 Exception으로 빼야할까요?(CouncilErrorCode처럼 따로 관리를 해야하는지 묻고싶습니다!)
관련 이슈
closes #463
체크리스트
reviewers설정label설정milestone설정