Skip to content

Fix incorrect pronouns in glitch-soc notifications #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ItsVipra
Copy link
Owner

@ItsVipra ItsVipra commented Jul 19, 2023

(i lied i looked into the issue further)

@nachtjasmin
Copy link
Contributor

nachtjasmin commented Jul 20, 2023

can't test it, if you think it's solved, merge it. ^^
Still I'm curious why you just don't return null in src/libs/protootshelpers.js ^^

@ItsVipra
Copy link
Owner Author

well it doesn't fix the double pronoun problem :D
can't seem to reproduce that either 🤔

@ItsVipra ItsVipra marked this pull request as ready for review August 1, 2023 09:58
@nachtjasmin nachtjasmin force-pushed the 65-someone-elses-pronoun-tag-gets-duplicated-on-random-users-sometimes-twice branch from 3f23d08 to 7af20f2 Compare August 1, 2023 13:57
@nachtjasmin nachtjasmin merged commit 2c6c39e into main Aug 1, 2023
@nachtjasmin nachtjasmin deleted the 65-someone-elses-pronoun-tag-gets-duplicated-on-random-users-sometimes-twice branch August 1, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Someone else's pronoun tag gets duplicated on random users (sometimes twice)
2 participants