Styled Components: Fix interpolated className #277
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/itsjonq/g2/9w5rDTVhEGpVEQkdyCXnxCYP5UQa |
|
Going to try an alpha |
| * @returns {string} The interpolated className. | ||
| */ | ||
| export function getInterpolatedClassName(displayName) { | ||
| return typeof displayName === 'string' ? `ic-${hash(displayName)}` : ''; |
There was a problem hiding this comment.
Should we raise a development-env warning that the displayName was undefined?
There was a problem hiding this comment.
Good idea. But maybe not here. Perhaps in contextConnect() or useContext()?
What you think :)
There was a problem hiding this comment.
Yup, that makes sense to me!
There was a problem hiding this comment.
I just pushed that update :). Lemme know if that works
This update consolidates how the interpolated className is created, in an attempt to resolve WordPress/gutenberg#29084 (comment)
Changes:
getInterpolatedClassNameutil is created and exported from@wp-g2/create-stylesgetInterpolatedClassNameensures the@emotion/hashfunction is only called if the argument is valid@wp-g2/contextadds@wp-g2/create-stylesas a dependency (was previously missing)@emotion/hashgo through the newgetInterpolatedClassNameutil