Skip to content

Add Serenity 4 Support #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 5, 2023
Merged

Add Serenity 4 Support #170

merged 4 commits into from
Oct 5, 2023

Conversation

grey-rain
Copy link
Collaborator

@grey-rain grey-rain commented Sep 27, 2023

Upgrade dependencies and make related changes to provide Serenity 4 support.
Note: Java 11 is required.

@grey-rain grey-rain requested a review from Invictum as a code owner September 27, 2023 16:33
@grey-rain grey-rain self-assigned this Sep 27, 2023
@grey-rain grey-rain mentioned this pull request Sep 27, 2023
README.md Outdated
@@ -3,7 +3,8 @@
Serenity integration with Report Portal
=======================================

Module allows to report Serenity powered tests to [reportportal.io](http://reportportal.io) server. Adds additional reporting to Serenity based test automation frameworks.
he module allows reporting Serenity-powered tests to [reportportal.io](http://reportportal.io) server and adds
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The, not "he"

Invictum
Invictum previously approved these changes Sep 29, 2023
@@ -37,34 +37,45 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<serenity.version>4.0.8</serenity.version>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: It might be beneficial to move report portal related libraries versions here as well.

README.md Outdated
1.3.0 | Minor version updated due to log units approach rework
1.4.0 - 1.4.3 | Minor version update: removed tree handler, refactored to support DDT for BDD
1.5.0+ | Minor version update due RP v5 release
4.0.0+ | Major version update due Serenity 4 release. Report Portal is updated to 5.8 as well
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 1.6.0

@grey-rain grey-rain merged commit 3d8418e into develop Oct 5, 2023
@grey-rain grey-rain deleted the serenity4_junit4 branch October 5, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants