Fix homogeneous transformation eq., typos, and remark about last row of ho. tr. matrix #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
correll
approved these changes
Nov 9, 2020
|
If you throw the last row away, it will still transform a 4x1 coordinate into a 3x1 coordinate: 3x1 = 3x4 * 4x1 but you do need your variables in 4x1 format to use them in this framework. This is why we are using a 4x4 matrix and get 4x1 = 4x4 * 4x1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are minor fixes @correll . Can you please check them?
I also saw that the last row
[0 0 0 1]of the transformation matrix is not required to integrate translation and rotation in a single operation. We could throw the last row away and the 3x4 matrix would still rotate and translate. Am I right?It would be great to clarify why we still take the 4x4 instead of 3x4 matrix.