Skip to content

Remove dead protocolInfoPraosBabbage and protocolInfoPraosShelleyBased. #4238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2022

Conversation

dnadales
Copy link
Member

@dnadales dnadales commented Dec 21, 2022

These functions were dead code, and I could not find any reference to in in cardano-node.

This enables a simpler Conway integration, which is in progress in #3971

Checklist

  • Branch
    • Commit sequence broadly makes sense
    • Commits have useful messages
    • New tests are added if needed and existing tests are updated
    • If this branch changes Consensus and has any consequences for downstream repositories or end users, said changes must be documented in interface-CHANGELOG.md
    • If this branch changes Network and has any consequences for downstream repositories or end users, said changes must be documented in interface-CHANGELOG.md
    • If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
  • Pull Request
    • Self-reviewed the diff
    • Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • Reviewer requested

@dnadales dnadales requested a review from nfrisby as a code owner December 21, 2022 14:22
@dnadales dnadales requested review from deepfire, eyeinsky, HeinrichApfelmus, Jimbo4350, kderme and newhoggy and removed request for eyeinsky December 21, 2022 14:23
@HeinrichApfelmus
Copy link
Contributor

Looks good from cardano-wallet downstream — I cannot find any usage of protocolInfoPraosBabbage or protocolInfoPraosShelleyBased, or more generally of the ProtocolInfo type. 👍

@dnadales dnadales merged commit c607a8d into master Dec 28, 2022
@iohk-bors iohk-bors bot deleted the remove-protocolInfo-variants branch December 28, 2022 12:04
@amesgen amesgen mentioned this pull request Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants