Remove Pretty from cardano-ledger-test
#4966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucsanszky
force-pushed
the
ldan/pretty-purge
branch
from
0995c79 to
c69debe
Compare
10 tasks
Lucsanszky
force-pushed
the
ldan/pretty-purge
branch
from
72093f3 to
8b6d1b7
Compare
Lucsanszky
force-pushed
the
ldan/pretty-purge
branch
6 times, most recently
from
ebdf176 to
c89a919
Compare
Lucsanszky
force-pushed
the
ldan/pretty-purge
branch
9 times, most recently
from
cfe2096 to
a5bcfdf
Compare
lehins
approved these changes
May 24, 2025
There was a problem hiding this comment.
Make sure to add all the instances introduced in this PR to the respective changelogs and this PR is good to go.
Awesome work. Thank you @Lucsanszky
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Classes.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Examples/STSTestUtils.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Generic/Fields.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Generic/Fields.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Generic/MockChain.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Generic/MockChain.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Generic/ModelState.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Generic/ModelState.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Generic/Trace.hs
Outdated
Show resolved
Hide resolved
Lucsanszky
force-pushed
the
ldan/pretty-purge
branch
from
84e07bc to
5421365
Compare
Lucsanszky
force-pushed
the
ldan/pretty-purge
branch
from
5421365 to
3a006d6
Compare
Changelogs are now updated as well. Thanks for the review and dead code removal suggestions! Finally, this is now done. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4873
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).hie.yamlupdated (usescripts/gen-hie.sh).