Skip to content

Fix enacted Set in GovInfoEvent #4604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 10, 2024
Merged

Fix enacted Set in GovInfoEvent #4604

merged 6 commits into from
Sep 10, 2024

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Sep 6, 2024

Description

Fix #4602

Besides the fix to GovInfoEvent this PR also:

  • Reduced duplication by consolidating to one implementation for generating uniform sub-Map and the same for uniform sub-Set. Three alternative implementations have been removed
  • Fixes implementation of uniformSubset. It had a really dumb bug (CC @neilmayhew see if you can spot this bug that I made in a very similar funciton 😄)

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins force-pushed the lehins/fix-GovInfoEvent branch 2 times, most recently from 0398b1f to e592c5d Compare September 7, 2024 00:11
@lehins lehins requested review from aniketd and neilmayhew September 9, 2024 19:07
@lehins lehins force-pushed the lehins/fix-GovInfoEvent branch from e592c5d to 4b38d9c Compare September 9, 2024 19:26
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just some questions and minor suggestions.

@lehins lehins force-pushed the lehins/fix-GovInfoEvent branch 2 times, most recently from ddf5a4e to 8477f3a Compare September 10, 2024 19:20
@lehins lehins enabled auto-merge September 10, 2024 19:20
@lehins lehins force-pushed the lehins/fix-GovInfoEvent branch from 8477f3a to 3d83339 Compare September 10, 2024 19:50
@lehins lehins merged commit dfc7006 into master Sep 10, 2024
156 checks passed
@lehins lehins deleted the lehins/fix-GovInfoEvent branch September 10, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GovInfoEvent incorrectly reports removed as enacted
2 participants