Skip to content

New output format flag for some commands #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 18, 2025
Merged

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented May 15, 2025

Changelog

- description: |
    New --output-json and --output-yaml flags for the following commands:
    * conway query committee-state
    * conway query constitution
    * conway query drep-stake-distribution
    * conway query drep-state
    * conway query future-pparams
    * conway query gov-state
    * conway query proposals
    * conway query ratify-state
    * latest query committee-state
    * latest query constitution
    * latest query drep-stake-distribution
    * latest query drep-state
    * latest query future-pparams
    * latest query gov-state
    * latest query proposals
    * latest query ratify-state
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

-> Parser (QueryNoArgCmdArgs era)
pQueryNoArgCmdArgs w envCli =
pQueryNoArgCmdArgs w envCli _name =
Copy link
Contributor

@Jimbo4350 Jimbo4350 May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the unused argument?

Edit: #1188 (comment)

@Jimbo4350 Jimbo4350 self-requested a review May 16, 2025 12:47
@newhoggy newhoggy added this pull request to the merge queue May 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 16, 2025
@newhoggy newhoggy added this pull request to the merge queue May 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 17, 2025
newhoggy added 3 commits May 17, 2025 21:56
* conway query committee-state
* conway query constitution
* conway query drep-stake-distribution
* conway query drep-state
* conway query future-pparams
* conway query gov-state
* conway query proposals
* conway query ratify-state
* latest query committee-state
* latest query constitution
* latest query drep-stake-distribution
* latest query drep-state
* latest query future-pparams
* latest query gov-state
* latest query proposals
* latest query ratify-state
@newhoggy newhoggy force-pushed the newhoggy/delete-writeOutput branch from dd2035d to b37aa2e Compare May 17, 2025 11:57
@newhoggy newhoggy added this pull request to the merge queue May 18, 2025
Merged via the queue into master with commit 6a654bd May 18, 2025
25 checks passed
@newhoggy newhoggy deleted the newhoggy/delete-writeOutput branch May 18, 2025 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants