Skip to content

More accurate format flags #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 15, 2025
Merged

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented May 14, 2025

Changelog

- description: |
    The `--output-cbor` flag has been split to `--output-cbor-bin` and `--output-cbor-hex`.
    The `query protocol-state` command now takes output format flags:
    * `--output-cbor-bin`
    * `--output-cbor-hex`
    * `--output-json`
    * `--output-yaml`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Implements ADR-012

How to trust this PR

Golden tests.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@newhoggy newhoggy force-pushed the newhoggy/more-accurate-format-flags branch from c6d5dd3 to 41d0d2e Compare May 14, 2025 12:21
@newhoggy newhoggy added this pull request to the merge queue May 15, 2025
Merged via the queue into master with commit 170158e May 15, 2025
26 checks passed
@newhoggy newhoggy deleted the newhoggy/more-accurate-format-flags branch May 15, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants