Skip to content

Rollout json pretty and yaml output 2 #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 13, 2025

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented May 11, 2025

Changelog

- description: |
    The following commands have been updated to take output format:
    * `conway query kes-period-info`
    * `conway query ledger-peer-snapshot`
    * `conway query pool-params`
    * `conway query pool-state`
    * `conway query protocol-parameters`
    * `conway query spo-stake-distribution`
    * `conway query stake-address-info`
    * `conway query stake-pool-default-vote`
    * `conway query stake-snapshot`
    * `conway query tip`
    * `conway query tx-mempool`
    * `conway query tx-mempool info`
    * `conway query tx-mempool next-tx`
    * `conway query tx-mempool tx-exists`
    * `latest query kes-period-info`
    * `latest query ledger-peer-snapshot`
    * `latest query pool-params`
    * `latest query pool-state`
    * `latest query protocol-parameters`
    * `latest query spo-stake-distribution`
    * `latest query stake-address-info`
    * `latest query stake-pool-default-vote`
    * `latest query stake-snapshot`
    * `latest query tip`
    * `latest query tx-mempool`
    * `latest query tx-mempool info`
    * `latest query tx-mempool next-tx`
    * `latest query tx-mempool tx-exists`
    * `query kes-period-info`
    * `query ledger-peer-snapshot`
    * `query pool-params`
    * `query pool-state`
    * `query protocol-parameters`
    * `query stake-address-info`
    * `query stake-snapshot`
    * `query tip`
    * `query tx-mempool`
    * `query tx-mempool info`
    * `query tx-mempool next-tx`
    * `query tx-mempool tx-exists`

# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Make it so that commands that output json can also output yaml as other similar commands have.

Additionally includes the following changes:

  • Consistent use outputFormat as the name of the output format field
  • Simplify with writeLazyByteStringOutput

How to trust this PR

Golden tests

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@newhoggy newhoggy marked this pull request as draft May 11, 2025 15:11
@newhoggy newhoggy marked this pull request as ready for review May 12, 2025 14:31
@newhoggy newhoggy changed the title Newhoggy/rollout json pretty and yaml output 2 Rollout json pretty and yaml output 2 May 12, 2025
@newhoggy newhoggy force-pushed the newhoggy/rollout-json-pretty-and-yaml-output-2 branch from 655628b to 83170a2 Compare May 12, 2025 21:27
@newhoggy newhoggy added this pull request to the merge queue May 13, 2025
Merged via the queue into master with commit 0aab284 May 13, 2025
26 checks passed
@newhoggy newhoggy deleted the newhoggy/rollout-json-pretty-and-yaml-output-2 branch May 13, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants