-
Notifications
You must be signed in to change notification settings - Fork 19
Standard output format for query ledger-peer-snapshot
command
#1172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standard output format for query ledger-peer-snapshot
command
#1172
Conversation
c1d7502
to
18a9fba
Compare
18a9fba
to
fb2871d
Compare
Perhaps json pretty format should be the default when outputting to a file, and otherwise plain json to the terminal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need output-json-pretty
?
What do you think about defaulting to pretty JSON everywhere? If the produced data is large, let's add CBOR output format as well, in case a faster and more efficient format is needed.
…napshot' command. Also support json-pretty and yaml output.
fb2871d
to
3affc83
Compare
@@ -114,6 +118,10 @@ cborToTextByteString bs = do | |||
text <- cborToText bs | |||
pure $ LB.fromStrict $ Text.encodeUtf8 text | |||
|
|||
cborToTextLazyByteString :: LB.ByteString -> ExceptT HelpersError IO LBS.ByteString |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must have backed out the change that used it.
Changelog
Context
Follows ADR-012
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist