Skip to content

Consistent output for query ledger-state cmd #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented May 5, 2025

Changelog

- description: |
    Consistent output for `query ledger-state` cmd
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@@ -805,7 +810,28 @@ runQueryLedgerStateCmd

result <- easyRunQuery (queryDebugLedgerState sbe)

pure $ shelleyBasedEraConstraints sbe (writeLedgerState mOutFile) result
-- format
-- & ( id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take is this isn't ready for review?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, Github opened an outdated version of the file for you.

@newhoggy newhoggy force-pushed the newhoggy/consistent-output-for-query-ledger-state-cmd branch from b7eccd3 to fc61ef4 Compare May 6, 2025 09:50
@newhoggy newhoggy force-pushed the newhoggy/consistent-output-for-query-ledger-state-cmd branch from fc61ef4 to 681e191 Compare May 6, 2025 09:57
@newhoggy newhoggy requested a review from Jimbo4350 May 6, 2025 10:37
@newhoggy newhoggy added this pull request to the merge queue May 6, 2025
Merged via the queue into master with commit 079b72c May 6, 2025
27 checks passed
@newhoggy newhoggy deleted the newhoggy/consistent-output-for-query-ledger-state-cmd branch May 6, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants