Skip to content

Fix incomplete pattern match error in transaction build using byron address #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

carbolymer
Copy link
Contributor

Changelog

- description: |
    Fix incomplete pattern match error in transaction build using byron address
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
   - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer marked this pull request as ready for review May 5, 2025 09:06
@carbolymer carbolymer linked an issue May 5, 2025 that may be closed by this pull request
@carbolymer carbolymer self-assigned this May 5, 2025
@carbolymer carbolymer force-pushed the mgalazyn/fix/incomplete-pattern-match-in-byron-address-building branch from c447846 to a492621 Compare May 5, 2025 09:13
@carbolymer carbolymer requested a review from mkoura May 5, 2025 13:10
@carbolymer carbolymer enabled auto-merge May 5, 2025 14:12
@carbolymer carbolymer added this pull request to the merge queue May 5, 2025
Merged via the queue into master with commit 9177ff0 May 5, 2025
27 of 28 checks passed
@carbolymer carbolymer deleted the mgalazyn/fix/incomplete-pattern-match-in-byron-address-building branch May 5, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pattern match failure when building tx with Byron address
3 participants