Skip to content

Consistent output for text-view decode-cbor command #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented May 4, 2025

Changelog

- description: |
    Consistent output for `text-view decode-cbor ` command
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Standardises on ADR-12

The default output format for text-view decode-cbor will be text because cbor output to stdout is not practical.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@newhoggy newhoggy changed the title Consistent output for text view info command Consistent output for text-view decode-cbor command May 4, 2025
@newhoggy newhoggy force-pushed the newhoggy/consistent-output-for-text-view-info-command branch from 12ab477 to c00548a Compare May 4, 2025 13:39
@newhoggy newhoggy force-pushed the newhoggy/consistent-output-for-text-view-info-command branch from c00548a to 412831f Compare May 4, 2025 13:48
@newhoggy newhoggy force-pushed the newhoggy/consistent-output-for-text-view-info-command branch from 412831f to e0a5114 Compare May 4, 2025 13:55
@newhoggy newhoggy added this pull request to the merge queue May 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 5, 2025
@newhoggy newhoggy added this pull request to the merge queue May 5, 2025
Merged via the queue into master with commit b11f652 May 5, 2025
24 of 25 checks passed
@newhoggy newhoggy deleted the newhoggy/consistent-output-for-text-view-info-command branch May 5, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants