Skip to content

Deprecate makeShelleyTransactionBody #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

carbolymer
Copy link
Contributor

Changelog

- description: |
    Deprecate `makeShelleyTransactionBody`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
   - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
   - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This duplicates createTransactionBody logic. createTransactionBody should be used insted.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer enabled auto-merge May 6, 2025 13:53
@carbolymer carbolymer added this pull request to the merge queue May 6, 2025
Merged via the queue into master with commit d47259d May 6, 2025
28 of 29 checks passed
@carbolymer carbolymer deleted the mgalazyn/refactor/deprecate-makeshelleytransactionbody branch May 6, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants