Skip to content

Fix autobalancing when there's no change. Add property test. #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

carbolymer
Copy link
Contributor

Changelog

- description: |
    Fix an autobalancing error needlessly thrown when there is no change in the transaction. Add property test for autobalancing.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
   - bugfix         # fixes a defect
   - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

n/a

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/fix/allow-for-zero-change-in-autobalancing branch from 62c3770 to 0f75db1 Compare April 25, 2025 09:42
@carbolymer carbolymer self-assigned this Apr 25, 2025
@carbolymer carbolymer force-pushed the mgalazyn/fix/allow-for-zero-change-in-autobalancing branch from 0f75db1 to 544b62d Compare April 25, 2025 09:52
mkoura added a commit to IntersectMBO/cardano-node-tests that referenced this pull request Apr 25, 2025
- Introduced a new blocker `api_829` for tracking the issue related to
  wrong autobalancing when there's no change in transactions.
- Updated `TestBasicTransactions` to handle the specific error message
  for minimum UTxO threshold.

The API issue: IntersectMBO/cardano-api#829
@carbolymer carbolymer force-pushed the mgalazyn/fix/allow-for-zero-change-in-autobalancing branch from 544b62d to 250a3be Compare April 25, 2025 10:44
@carbolymer carbolymer force-pushed the mgalazyn/fix/allow-for-zero-change-in-autobalancing branch from 250a3be to e7fc648 Compare April 28, 2025 21:26
@carbolymer carbolymer requested a review from Jimbo4350 April 28, 2025 21:27
@Jimbo4350
Copy link
Contributor

Nice 👍

@carbolymer carbolymer force-pushed the mgalazyn/fix/allow-for-zero-change-in-autobalancing branch from e7fc648 to 45a2127 Compare April 29, 2025 13:08
@carbolymer carbolymer enabled auto-merge April 29, 2025 13:08
@carbolymer carbolymer added this pull request to the merge queue Apr 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 29, 2025
@carbolymer carbolymer added this pull request to the merge queue Apr 29, 2025
Merged via the queue into master with commit 25e5f83 Apr 29, 2025
29 checks passed
@carbolymer carbolymer deleted the mgalazyn/fix/allow-for-zero-change-in-autobalancing branch April 29, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants