Skip to content

Remove BabbageEra from experimental Era type #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

Remove BabbageEra from experimental Era type #828

merged 1 commit into from
Apr 25, 2025

Conversation

palas
Copy link
Contributor

@palas palas commented Apr 24, 2025

Changelog

- description: |
    Removed Babbage era from `Experimental` API together with `babbageEraOnwardsToEra` function.
  type:
  - breaking

Context

This PR addresses #827. It is part of an effort to propagate the experimental API through cardano-cli. Because Babbage era is deprecated we are removing it from the experimental API.

How to trust this PR

Check just the right things are removed and the updates make sense. The fact that it typechecks already gives a lot of assurance in this particular case.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas self-assigned this Apr 24, 2025
@palas palas linked an issue Apr 24, 2025 that may be closed by this pull request
Update new Era construct to not include the deprecated era Babbage #827
Closed
carbolymer
carbolymer reviewed Apr 25, 2025
View reviewed changes
@palas palas force-pushed the remove-babbage-from-experimental-era-type branch from 9bc4a0d to b03d68a Compare April 25, 2025 11:17
@palas palas force-pushed the remove-babbage-from-experimental-era-type branch from b03d68a to 8953632 Compare April 25, 2025 11:17
@palas palas requested a review from carbolymer April 25, 2025 11:18
Jimbo4350
Jimbo4350 approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, how does this look in cardano-cli?

@palas
Copy link
Contributor Author

palas commented Apr 25, 2025

Nice, how does this look in cardano-cli?

It just affects two lines, where there was a case over the era. Very small changes

@palas palas added this pull request to the merge queue Apr 25, 2025
Merged via the queue into master with commit 283b2af Apr 25, 2025
29 checks passed
@palas palas deleted the remove-babbage-from-experimental-era-type branch April 25, 2025 14:51
@palas palas mentioned this pull request May 26, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbolymer carbolymer carbolymer approved these changes

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts dcoutts is a code owner

@erikd erikd Awaiting requested review from erikd erikd is a code owner

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara CarlosLopezDeLara is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

Assignees

@palas palas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update new Era construct to not include the deprecated era Babbage
3 participants
@palas @carbolymer @Jimbo4350