Skip to content

Add HasTextEnvelope instance for EraHistory #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2025
Merged

Conversation

palas
Copy link
Contributor

@palas palas commented Mar 5, 2025

Changelog

- description: |
    Added `HasTextEnvelope` instance for `EraHistory`
  type:
  - feature        # introduces a new feature
  - compatible     # the API has changed but is non-breaking

Context

This change in the API is required to support the related PR in cardano-cli: IntersectMBO/cardano-cli#1079

How to trust this PR

I would look at all the changes, which are few. The fact that it type-checks already gives a lot of guarantee. The approach is pretty similar to that of other HasTextEnvelope instances. The tests in the related cardano-cli PR can offer further assurance.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM however where is this being used?

@palas palas self-assigned this Mar 6, 2025
@palas
Copy link
Contributor Author

palas commented Mar 6, 2025

@Jimbo4350 Jimbo4350 self-requested a review March 6, 2025 12:58
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 . Could you add a small haddock just explaining where this is consumed.

@palas palas enabled auto-merge March 6, 2025 16:21
@palas palas added this pull request to the merge queue Mar 6, 2025
Merged via the queue into master with commit 7d13491 Mar 6, 2025
29 checks passed
@palas palas deleted the query-interpreter branch March 6, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] - Command to calculate the correct Plutus Script Costs offline
3 participants