Skip to content

Fix mutability issue leading to wrong behavior in //ascend and //descend #3101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

SirYwell
Copy link
Member

@SirYwell SirYwell commented Feb 3, 2025

Overview

Description

//ascend and //descend functionality used a mutable vector, but the vector got modified in another method. This caused the commands to misbehave. Simply reverting to the original WE code fixes that. As this isn't performance critical, using immutable vectors seems to be fine.

### Submitter Checklist
- [x] Make sure you are opening from a topic branch (**/feature/fix/docs/ branch** (right side)) and not your main branch.
- [x] Ensure that the pull request title represents the desired changelog entry.
- [x] New public fields and methods are annotated with `@since TODO`.
- [x] I read and followed the [contribution guidelines](https://github.com/IntellectualSites/.github/blob/main/CONTRIBUTING.md).

@SirYwell SirYwell requested a review from a team as a code owner February 3, 2025 16:19
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Feb 3, 2025
@dordsor21 dordsor21 requested a review from a team February 9, 2025 09:02
@SirYwell SirYwell merged commit 61f4a48 into main Feb 11, 2025
9 checks passed
@SirYwell SirYwell deleted the fix/ascend-descend-mutability branch February 11, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix This PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants